Add Icons clearing issue backlog #870
Conversation
|
You should've received an email with an invite for Triage permissions so you can easily manage and link the issues :) |
Got it, cheers! Happy to do so. Do we want to add a label for incidents where no logo is available? |
|
Great idea! |
|
Something is weird with the icinga icons, they don't have the whitespace in either Illustrator or SVG Crop, but the files are in sync... |
Might be a hard coded width and height in the icons, I'll check the raw files! |
You might be right, just spotted some hidden assets off the canvas. |
Signed-off-by: Bjorn Lammers <[email protected]>
|
Can't seem to directly fix the icinga-full icons. |
stuntguy3000
force-pushed
the
add-icons
branch
3 times, most recently
from
d626b02 to
ca144a1
Compare
|
Tried a whole bunch of different things, I strongly suspect this is somehow related to the viewbox and/or transform attributes - but no number of tools (or ChatGPT) can quite crack it. Must be fixable, but by an SVG expert, or someone who likes banging their head against a wall. |
|
Ready for overall review and merging @walkxcode |
Update, I've fixed the broken images. I was close, but not close enough. Scratch notes added here, let me know if you want me to commit them too. |
If you can integrate these changes more seamlessly, feel free to submit a PR. Great additions! :D |
Add Icons clearing issue backlog, closing a number of issues and adding a variety of icons and services.