Chore/cleanup make private #130
Conversation
| @@ -14,7 +14,7 @@ crate-type = ["cdylib", "rlib"] | |||
| path = "src/guest.rs" | |||
|
|
|||
| [dependencies] | |||
| holochain_serialized_bytes = { version = "=0.0.55", features = [] } | |||
| holochain_serialized_bytes = "=0.0.55" | |||
There was a problem hiding this comment.
Cargo features are additive and this dep does not specify default-features = false, so I believe features = [] has no effect.
| @@ -385,16 +383,6 @@ impl ModuleCache { | |||
| } | |||
| } | |||
|
|
|||
| /// Configuration of a Target for wasmer for iOS | |||
| pub fn wasmer_ios_target() -> Target { | |||
There was a problem hiding this comment.
This is not used anywhere in holochain. If needed later we can restore it.
crates/host/src/module/mod.rs
Outdated
There was a problem hiding this comment.
Made several types private that are only used internally
| ./scripts/bench-wasmer_sys_dev.sh | ||
| ./scripts/bench-wasmer_sys_prod.sh | ||
| ./scripts/bench-wasmer_wamr.sh |
There was a problem hiding this comment.
Now this script runs properly from the root directory only.
| ./scripts/test-wasmer_sys_dev.sh | ||
| ./scripts/test-wasmer_sys_prod.sh | ||
| ./scripts/test-wasmer_wamr.sh |
There was a problem hiding this comment.
Now this script runs properly from the root directory only.
test/benches/bench.rs
Outdated
There was a problem hiding this comment.
rename file to follow preferred convention for modules
crates/host/src/module.rs
Outdated
| @@ -104,12 +100,14 @@ pub trait PlruCache { | |||
|
|
|||
| /// Delete the plru for a given cache key. Care must be taken to ensure this | |||
| /// is not called before a subsequent call to `plru_key` or it will panic. | |||
| #[allow(dead_code)] | |||
| fn trash(&mut self, key: &CacheKey) { | |||
There was a problem hiding this comment.
Are these really used? It's a private method on a private type now right?
If these are only used in tests I'd prefer #[cfg(test)] over dead_code
There was a problem hiding this comment.
No they're not used anywhere, though I thought they might be in the future if we do any pruning of the cache.
But they are very simple and can be added back if needed. Removed.
Some minor cleanup to this repo.