Skip to content

Commit

Permalink
Make js_finish_deferred_teardown_callback() the very last call
Browse files Browse the repository at this point in the history
  • Loading branch information
kasperisager committed Nov 28, 2024
1 parent cd415bd commit 9c49ccd
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions binding.c
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,8 @@ bare_pipe__on_close(uv_handle_t *handle) {

js_env_t *env = pipe->env;

js_deferred_teardown_t *teardown = pipe->teardown;

js_handle_scope_t *scope;
err = js_open_handle_scope(env, &scope);
assert(err == 0);
Expand All @@ -286,9 +288,6 @@ bare_pipe__on_close(uv_handle_t *handle) {
err = js_get_reference_value(env, pipe->on_close, &on_close);
assert(err == 0);

err = js_finish_deferred_teardown_callback(pipe->teardown);
assert(err == 0);

err = js_delete_reference(env, pipe->on_connection);
assert(err == 0);

Expand All @@ -314,6 +313,9 @@ bare_pipe__on_close(uv_handle_t *handle) {

err = js_close_handle_scope(env, scope);
assert(err == 0);

err = js_finish_deferred_teardown_callback(teardown);
assert(err == 0);
}

static void
Expand Down

0 comments on commit 9c49ccd

Please sign in to comment.