GET methods should not have bodies

holepunchto · Jun 12, 2024 · ba00247 · ba00247
1 parent e0b1736
commit ba00247
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/client-request.js b/lib/client-request.js
@@ -30,7 +30,7 @@ module.exports = class HTTPClientRequest extends HTTPOutgoingMessage {
     this.headers = { host: host + ':' + port, ...opts.headers }
 
     this._connection = connection
-    this._chunked = true
+    this._chunked = method !== 'GET' && method !== 'HEAD'
 
     this._pendingFinal = null
 

diff --git a/test.js b/test.js
@@ -272,7 +272,7 @@ test('chunked', async function (t) {
   await waitForServer(server)
 
   const reply = await request({
-    method: 'GET',
+    method: 'POST',
     host: server.address().address,
     port: server.address().port,
     path: '/'
@@ -362,7 +362,7 @@ test('server and client do big writes', async function (t) {
   await waitForServer(server)
 
   const reply = await request({
-    method: 'GET',
+    method: 'POST',
     host: server.address().address,
     port: server.address().port,
     path: '/'