Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sscsci 1478: iba google tag manager #1148

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Sscsci 1478: iba google tag manager #1148

wants to merge 10 commits into from
+12 −5

Conversation

Tim97eng
Copy link
Contributor

@Tim97eng Tim97eng commented Jan 8, 2025

Jira link

See SSCSCI-1478

Change description

  • Adding a global var when logged in to check what benefit type is active
  • When in IBA, a different google tag is being used else uses the existing one

Testing done

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@Tim97eng Tim97eng requested a review from a team as a code owner January 8, 2025 17:12
linusnorton
linusnorton requested changes Jan 9, 2025
View reviewed changes
Copy link

@linusnorton linusnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

writing to an env var isn't a great way of managing this

@Tim97eng Tim97eng force-pushed the SSCSCI-1478-iba-tag-manager branch from 2b33d5d to d824e72 Compare January 9, 2025 17:48
@Tim97eng Tim97eng requested a review from linusnorton January 9, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linusnorton linusnorton Awaiting requested review from linusnorton

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enable_keep_helm ns:sscs prd:sscs-cor rel:sscs-cor-frontend-pr-1148
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tim97eng @linusnorton