Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fixed the added benefit appeal post code check #1147

Merged
merged 20 commits into from
Jan 14, 2025
Merged

test: fixed the added benefit appeal post code check #1147

merged 20 commits into from
Jan 14, 2025

Conversation

pats-john
Copy link

@pats-john pats-john commented Jan 7, 2025 •
edited by benouaer
Loading

Jira link

Change description

  • update test to select appealType before selecting postcode

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@pats-john pats-john requested a review from a team as a code owner January 7, 2025 16:26
@pats-john pats-john changed the base branch from master to nightly-dev January 7, 2025 16:26
@nilay913 nilay913 changed the base branch from nightly-dev to master January 7, 2025 16:36
@nilay913 nilay913 changed the base branch from master to nightly-dev January 7, 2025 16:37
@pats-john pats-john changed the base branch from nightly-dev to master January 7, 2025 16:49
ArunabhaChowdhury
ArunabhaChowdhury reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@ArunabhaChowdhury ArunabhaChowdhury left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pats-john please uncomment the welsh test, after step and firefox and webkit browser configs. Happy to jump on a call if you need.

@benouaer benouaer merged commit 16e95f9 into master Jan 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArunabhaChowdhury ArunabhaChowdhury ArunabhaChowdhury left review comments

@nilay913 nilay913 nilay913 approved these changes

Assignees
No one assigned
Labels
ns:sscs prd:sscs-cor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pats-john @nilay913 @ArunabhaChowdhury @benouaer @gemmatalbot @katkovacs @NHAL22