-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTSPB-4486 Improve Notify error reporting #2951
Open
tom-saunders-cts
wants to merge
4
commits into
master
Choose a base branch
from
DTSPB-4486-improve-notify-error-handling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCD diff reportNo change |
tom-saunders-cts
force-pushed
the
DTSPB-4486-improve-notify-error-handling
branch
from
January 9, 2025 12:59
d2519f8
to
d35d8e6
Compare
CCD diff reportNo change |
tom-saunders-cts
force-pushed
the
DTSPB-4486-improve-notify-error-handling
branch
from
January 9, 2025 13:43
d35d8e6
to
7493ba8
Compare
CCD diff reportNo change |
tom-saunders-cts
force-pushed
the
DTSPB-4486-improve-notify-error-handling
branch
from
January 9, 2025 14:29
7493ba8
to
254906a
Compare
CCD diff reportNo change |
hmcts-jenkins-j-to-z
bot
added
ns:probate
prd:probate
rel:probate-back-office-pr-2951
labels
Jan 9, 2025
CCD diff reportNo change |
tom-saunders-cts
force-pushed
the
DTSPB-4486-improve-notify-error-handling
branch
from
January 10, 2025 08:27
f71394f
to
d611763
Compare
CCD diff reportNo change |
CCD diff reportNo change |
tom-saunders-cts
force-pushed
the
DTSPB-4486-improve-notify-error-handling
branch
from
January 15, 2025 15:22
07aa4c3
to
b556f97
Compare
CCD diff reportNo change |
tom-saunders-cts
force-pushed
the
DTSPB-4486-improve-notify-error-handling
branch
from
January 15, 2025 15:35
b556f97
to
37a3f74
Compare
CCD diff reportNo change |
We probably shouldn't use an exception provided by a dependency for this.
tom-saunders-cts
force-pushed
the
DTSPB-4486-improve-notify-error-handling
branch
from
January 21, 2025 10:47
37a3f74
to
29e4246
Compare
CCD diff reportNo change |
FeliTam
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
See DTSPB-4486
Change description
Adds a new exception type for non-notify email errors. moves the Notify exception handler into its own class.
Does this PR introduce a breaking change? (check one with "x")