-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFDIV-4448: Add configuration for NFD case deletion #4252
base: master
Are you sure you want to change the base?
Conversation
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/system-update-TTL.json
|
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/system-update-TTL.json
|
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/system-update-TTL.json
|
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/system-update-TTL.json
|
src/main/java/uk/gov/hmcts/divorce/citizen/event/CitizenUpdateApplication.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/divorce/systemupdate/event/SystemUpdateTTL.java
Outdated
Show resolved
Hide resolved
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/system-update-TTL.json
|
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/system-update-TTL.json
|
1 similar comment
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/system-update-TTL.json
|
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/system-update-TTL.json
|
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/system-update-ttl.json
|
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/system-update-ttl.json
CaseEventToFields/system-update-ttl.json
|
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/system-update-ttl.json
CaseEventToFields/system-update-ttl.json
|
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/system-update-ttl.json
CaseEventToFields/system-update-ttl.json
|
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/system-update-ttl.json
CaseEventToFields/system-update-ttl.json
|
.data(details.getData()) | ||
.state(details.getState()) | ||
.build(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to set the TTL in citizenCreateApplication and solicitorCreateApplication to avoid old drafts being left from the start of the application process? It might work using ttlIncrement rather than a custom event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added TtlIncreament to be 180 days (6 months) as suggested
@@ -46,6 +46,7 @@ public void configure(final ConfigBuilder<CaseData, State, UserRole> configBuild | |||
.event(CITIZEN_PAYMENT_MADE) | |||
.forState(AwaitingPayment) | |||
.showCondition(NEVER_SHOW) | |||
.ttlIncrement(36524) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to account for the scenarios where a sol submits an application or a citizen submits using HWF?
if (caseData.getRetainAndDisposeTimeToLive() == null && details.getState() == Draft) { | ||
caseData.setRetainAndDisposeTimeToLive(TTL.builder().systemTTL(CURRENT_DATE_PLUS_SIX_MONTH) | ||
.suspended(YesOrNo.NO) | ||
.build()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we'll need to set it like this if using TTL Increment? I'm not sure R&D allows it to be manually set without going through CCD config (based on discussions last week)
public class SystemUpdateTTL implements CCDConfig<CaseData, State, UserRole> { | ||
|
||
public static final String SYSTEM_UPDATE_TTL = "system-update-ttl"; | ||
private static final LocalDate CURRENT_DATE_PLUS_SIX_MONTH = LocalDate.now().plusMonths(6); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it's static, it will get initialised once (when a pod starts), meaning that if we have long-running pods, the TTL will be too short for some cases
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/manage-case-ttl.json
CaseEventToFields/manage-case-ttl.json
|
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/manage-case-ttl.json
CaseEventToFields/manage-case-ttl.json
|
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/manage-case-ttl.json
CaseEventToFields/manage-case-ttl.json
|
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/manage-case-ttl.json
CaseEventToFields/manage-case-ttl.json
|
src/main/java/uk/gov/hmcts/divorce/systemupdate/event/ManageCaseTtl.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/divorce/common/ccd/HighLevelDataSetupApp.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/divorce/divorcecase/model/CaseData.java
Outdated
Show resolved
Hide resolved
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-divorce-systemupdate.json
AuthorisationCaseField/caseworker-divorce-superuser.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/manageCaseTTL.json
CaseEventToFields/manageCaseTTL.json
|
CCD diff reportAuthorisationCaseState.json
AuthorisationCaseType.json
CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-divorce-systemupdate.json
AuthorisationCaseField/caseworker-divorce-superuser.json
AuthorisationCaseField/TTL_profile.json
CaseEvent/manageCaseTTL.json
CaseEventToFields/manageCaseTTL.json
|
Change description
Add configuration for NFD case deletion
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/NFDIV-4448
Pull request checklist
Before raising
Before merging
Note: Bug fixes, dependency updates and technical tasks do not directly impact the user experience and can be merged without QA and PO review.