NFDIV-4355 - Send email and letter to citizen when representation is removed by CW #4168
Conversation
| if (beforeApplicant.getEmail() != null && !beforeApplicant.getEmail().isBlank() | ||
| && (applicant.getEmail() == null || applicant.getEmail().isBlank())) { |
There was a problem hiding this comment.
Nit: I was thinking we could start simplifying this common pattern we have in the code with StringUtils to make it easier to read 🤔
| if (beforeApplicant.getEmail() != null && !beforeApplicant.getEmail().isBlank() | |
| && (applicant.getEmail() == null || applicant.getEmail().isBlank())) { | |
| if (isNotBlank(beforeApplicant.getEmail()) && isBlank(applicant.getEmail())) { |
There was a problem hiding this comment.
Suggested change made
| if (data.getApplicationType() == ApplicationType.SOLE_APPLICATION) { | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Nit:
| if (data.getApplicationType() == ApplicationType.SOLE_APPLICATION) { | |
| return true; | |
| } | |
| return false; | |
| return data.getApplicationType() == ApplicationType.SOLE_APPLICATION; |
There was a problem hiding this comment.
Suggested change made
| @@ -49,6 +49,23 @@ public void sendNOC(final ApplicantNotification applicantNotification, | |||
| } | |||
| } | |||
|
|
|||
| // Need different logic for NOC notification when sending invite to citizen | |||
| public void sendNOCToParty(final ApplicantNotification applicantNotification, | |||
There was a problem hiding this comment.
I'm not sure how best to name this so people can distinguish it from sendNOC in the future - do you think we should include CaseInvite in the name and then you may be able to remove the comment?
| public void sendNOCToParty(final ApplicantNotification applicantNotification, | |
| public void sendNOCCaseInvite(final ApplicantNotification applicantNotification, |
There was a problem hiding this comment.
Changes made to rename method
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed because it has been stalled for 2 days with no activity. |
Change description
Send email and letter to citizen when representation is removed by CW.
Send to joint applicants if both applicants are already identified in system as online.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/NFDIV-4355