Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled max_resub #40

Merged
merged 3 commits into from
Nov 20, 2024
Merged

disabled max_resub #40

merged 3 commits into from
Nov 20, 2024

Conversation

jwtoney
Copy link
Contributor

@jwtoney jwtoney commented Oct 30, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 11.23%. Comparing base (1e82650) to head (e740056).

Files with missing lines Patch % Lines
jobmanager/resub.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   11.22%   11.23%           
=======================================
  Files          15       15           
  Lines        3776     3774    -2     
=======================================
  Hits          424      424           
+ Misses       3352     3350    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@aarongarrison aarongarrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! These changes help with running on supercloud and for short refresh times when reading the output file might not work as expected.

@aarongarrison aarongarrison merged commit 83c1d2a into main Nov 20, 2024
5 checks passed
@aarongarrison aarongarrison deleted the disable_max_resub branch November 20, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants