added emails status across email calls taking place in views #216
Conversation
|
@PonteIneptique |
|
app/account/views.py
Outdated
| invite_link=invite_link) | ||
| if not current_app.config["SEND_MAIL_STATUS"]: |
There was a problem hiding this comment.
Indentation error here :) https://travis-ci.org/github/hipster-philology/pyrrha/builds/733332760#L329
|
I cannot yet close the PR but I really want to thank you @saisiddhant12 for your work 👍 |
|
fixed the indentation issue, you can take a look now, let me know what more it takes to close the PR |
app/account/views.py
Outdated
| 'warning') | ||
| else: | ||
| flash('You are running in dev or test mode. Your account needs' | ||
| ' to be confirmed via the command line interface or through the CLI') |
There was a problem hiding this comment.
I am sorry I did not catch this sooner: you are missing the secondary argument "warning" here:
flash('You are running in dev or test mode. Your account needs'
' to be confirmed via the command line interface or through the CLI', 'warning')
|
I am waiting for the CI but I tested it locally and it looks ok :) I'll keep it updated ;) |
|
I assume you're here for Hacktoberfest, do I need to something specific once the PR is merged ? |
|
Apart from the PR getting merged, |
|
There are two tests which do not pass anymore, I'll deal with them with a technical-debt :) |
|
Thank you very much @saisiddhant12 :) |
Commit wrt #215 for handling mail send and dont send feature