Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Log all the config data decoding errors #51

Merged
merged 1 commit into from
Jan 5, 2024
Merged

feat: Log all the config data decoding errors #51

merged 1 commit into from
Jan 5, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Jan 5, 2024

No description provided.

@CH3CHO CH3CHO requested a review from johnlanni as a code owner January 5, 2024 01:12
johnlanni
johnlanni approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit c93a312 into higress-group:main Jan 5, 2024
2 checks passed
@CH3CHO CH3CHO deleted the feat/decode-error-logs branch January 9, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnlanni johnlanni johnlanni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CH3CHO @johnlanni