Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mirror Node Contract Queries #1188

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Dec 13, 2024

Description:

A new MirrorNodeContractQuery class has been introduced to support EVM gas estimation and simulation. This query class provides two distinct types of queries:

  1. MirrorNodeContractCallQuery – Executes a contract call and returns the result, simulating the execution of the contract.
  2. MirrorNodeContractEstimateGasQuery – Estimates the gas usage for a contract call, allowing developers to understand the cost of executing a transaction.

The inputs for these queries match those of ContractExecuteTransaction, making it easy for developers to calculate the cost of a follow-up transaction.

The MirrorNodeContractQuery issues an HTTP request to the api/v1/contracts/call endpoint of the Mirror Node Web3 module, which supports both gas estimation and transient simulation of state-changing transactions. This enables accurate cost predictions and helps developers optimize their contract interactions before executing them on the network.

Related issue(s):

Fixes #1167

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov 0xivanov added the enhancement New feature or request label Dec 13, 2024
@0xivanov 0xivanov self-assigned this Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov 0xivanov marked this pull request as ready for review December 17, 2024 13:30
@0xivanov 0xivanov requested review from a team as code owners December 17, 2024 13:30
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits and needs a little design tweak. Otherwise LG.

account_id.go Outdated Show resolved Hide resolved
mirror_node_contract_call_query.go Show resolved Hide resolved
mirror_node_contract_estimate_gas_query.go Outdated Show resolved Hide resolved
Signed-off-by: Ivan Ivanov <[email protected]>
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@0xivanov 0xivanov merged commit 2d06610 into main Dec 18, 2024
5 of 6 checks passed
@0xivanov 0xivanov deleted the 1167-mirror-node-contract-queries branch December 18, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a query to estimate the gas of a contract call
2 participants