Merge Admin / Mods Page with Groups and Members Page #10580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@salman-neslit Are you sure all requirements from the ticket have been fulfilled in this PR? For example, ticket mentions "We should remove one of the two from the sidebar", yet I'm still seeing Admins & Moderators as a tab in the sidebar. Seems that if there is a Manage On Chain Role Privileges functionality in Members & Groups, then the Admins & Moderators page should be removed. |
Israellund
reviewed
Jan 21, 2025
...ient/scripts/views/pages/CommunityGroupsAndMembers/Members/MembersSection/MembersSection.tsx
Show resolved
Hide resolved
|
@Israellund I also left the note above regarding the removal of previous funcnality will be handled in the follow up PR. as there is another issue that also needs to be addressed Issue#9521 these 2 are linked |
Israellund
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9978
Description of Changes
"How We Fixed It"
Test Plan
Deployment Plan
Other Considerations