Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix epoch in send message #25

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Fix epoch in send message #25

merged 2 commits into from
Dec 9, 2023

Conversation

hickey
Copy link
Owner

@hickey hickey commented Dec 7, 2023

This fixes the problem of creating messages with bad or bogus timestamps when epoch is not specified in the send_message API call.

Closes #15

@hickey hickey added the bug Something isn't working label Dec 7, 2023
@hickey hickey added this to the v2.10 milestone Dec 7, 2023
@hickey hickey requested a review from gerner December 7, 2023 23:28
@hickey hickey self-assigned this Dec 7, 2023
Copy link
Collaborator

@gerner gerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with this bug, but LGTM

meshchat Show resolved Hide resolved
@n2mh
Copy link

n2mh commented Dec 8, 2023

Would it also make sense to also do a simple check to see if an incoming timestamp is in the future? If so, discard it and use the present time? Or, some other action?

@hickey
Copy link
Owner Author

hickey commented Dec 8, 2023

I have been thinking about putting guardrails around the epoch value, but I am not certain what the appropriate amount of variance is good. The code from KN6PLV was allowing up to 30 days in the future (which I think is still there) but that seems way too excessive to me. Nodes tend to be lousy time keepers and so there certainly should be a +/- number of secs or mins that a message would be allowed to have. If anyone has any suggestions, I am willing to give it a try with suggested time deltas. I will actually put values in the config file so that it can be tuned rather than constantly releasing new code trying to find good values.

@hickey hickey merged commit 1357fca into master Dec 9, 2023
2 checks passed
@hickey hickey deleted the fix-epoch-in-send-message branch February 6, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Messages not appearing in UI
3 participants