chore: enforcing API consistency (also across FFI) #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
returning a String was weird!
so now it creates a table on the fly and the thing that lua receives behaves like you would expect instead of being weird!
Co-authored-by: zaaarf <[email protected]>
zaaarf
added
core
This was referenced Oct 15, 2024
…s and fetch_buffers Co-authored-by: alemi <[email protected]>
Co-authored-by: alemi <[email protected]>
ghyatzo
requested changes
Oct 16, 2024
zaaarf
changed the title
alemidev
previously approved these changes
Oct 16, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
frelodev
requested changes
Oct 16, 2024
Co-authored-by: frelodev <[email protected]>
…nd password as mandatory.
frelodev
approved these changes
Oct 16, 2024
ghyatzo
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make development easier, so far we've been lax enough with naming and typing.
In an effort to make the API more consistent across languages (and to amend some questionable naming choices) we're doing a round of mass renaming. And, in some cases, of adding stuff that probably should've been there and bugfixing (especially in the realm of inconsistent method signatures).
Honorable mentions: the method formerly known as
list_buffer_users, who was implemented correctly in the glue a grand total of 1 time (JavaScript, gg @frelodev).Feel free to add any fixes if we missed anything.