Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: how to import volumes #860

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

docs: how to import volumes #860

wants to merge 3 commits into from

Conversation

lukasmetzner
Copy link
Contributor

No description provided.

@lukasmetzner lukasmetzner requested a review from a team as a code owner January 22, 2025 12:13
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.35%. Comparing base (522441b) to head (8bbb706).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #860   +/-   ##
=======================================
  Coverage   32.35%   32.35%           
=======================================
  Files          21       21           
  Lines        2077     2077           
=======================================
  Hits          672      672           
  Misses       1371     1371           
  Partials       34       34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jooola
jooola requested changes Jan 22, 2025
View reviewed changes
Copy link
Member

@jooola jooola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about moving the hcloud cli command in real block quotes? This makes it easier to copy and paste compared to inline code in the text.

docs/kubernetes/how-to-import-volumes.md Outdated Show resolved Hide resolved
docs/kubernetes/how-to-import-volumes.md Outdated Show resolved Hide resolved
@lukasmetzner lukasmetzner requested a review from apricote January 23, 2025 11:51
apricote
apricote approved these changes Jan 23, 2025
View reviewed changes
docs/kubernetes/how-to-import-volumes.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jooola jooola jooola requested changes

@apricote apricote apricote approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasmetzner @apricote @jooola