Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): add err handle when input bad format email #3

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

avtara
Copy link
Collaborator

@avtara avtara commented May 31, 2020

No description provided.

@avtara avtara added the enhancement New feature or request label May 31, 2020
@avtara avtara requested a review from BlinfoldKing May 31, 2020 13:06
src/auth/auth.entity.ts Outdated Show resolved Hide resolved
src/auth/auth.entity.ts Outdated Show resolved Hide resolved
src/auth/auth.entity.ts Outdated Show resolved Hide resolved

type RegisterResult = {
id?: string,
token?: string,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kenapa optional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soalnya kalo error ga ngembaliin id sama token jadinya di optionalin, gitu

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

harus nya gausah kalo error promise nya aja yang di throw error

@avtara avtara requested a review from BlinfoldKing June 1, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants