Refactor entities and migrate unique IDs #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Sensors now implement translation key for icons and name
…iption breaking: status register unique id, renamed because of ambiguities
…the meter serial number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor sensors and binary sensors creation, for better maintainability, translate entities name and icon with the
translation_keyfeature, and provide fr/en translationsFix
Mode Historiquebinary sensor valueFix binary sensors
BinarySensorDeviceClassinconsistenciesMigrate config and entities unique IDs, with meter serial number as the unique ID source (existing config and sensors will be migrated without data loss)
IMPORTANT: This bumps the
ConfigFlowto version 2.0, which means migration is irreversible (downgrading component will result in a unfixable migration error for newer/migrated configs)For data validity, the device serial number will be read at setup and compared to the config serial number, to prevent another meter data to overwrite long term statistics
TODO: update the config/option flow to permit change of the serial port (e.g. in case of hardware upgrade)
Test migration for standard configuration (monophase, non-producer)
Test migration for historic configuration (monophase + threephase)
PS: je suis preneur pour tester la migration du mode historique (ou bien depuis ma branche, ou je peux le faire depuis un conteneur de test si on me fourni quelques trames hitoriques)