fix: safari copy item issue #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I am very busy recently. Thank you for your PR, I will check it as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
effectAllowedwe can not rely on drag event properties since different browsers give different results. In Safari (MacOS) I always received effectAllowed = 'all', does not matter I assign the property (effect-allowed) tovddl-draggableor not. It always triggers move effect. So what I did here is except relying on browser's event, I made the tweak on existing prototype object (vddlDropEffectWorkaround.dropEffect) that you created for wired browser behavior. It solves my issue.Please accept my pull request, if you don't, tell me what else we can do to solve this quirk.