Add .gds.gz support to read_gds() and shape tags and layer tags filtering to read_oas() #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and reallocating uninitialized array items pointer
fix spacing
This was referenced Dec 19, 2024
|
Is there any such thing as a regression test I can build to help validate these changes? |
|
Does anybody have an application that uses GDSTK as-is with no modification, that I could use to test my code changes more? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am still learning how to build the tests so I have not tested these code changes enough yet, but I think everything is here.
From issue #280 (give read_oas() shape and label tags)
And issue #222 (support .gds.gz files in read_gds(), NOT supported for writing yet)