This repository has been archived by the owner on Feb 28, 2023. It is now read-only.
Add support for idempotency_key and timestamp #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macobo
force-pushed
the
timestamp-idempotency-key
branch
2 times, most recently
from
c397ec9 to
736f9bb
Compare
macobo
force-pushed
the
timestamp-idempotency-key
branch
3 times, most recently
from
d74acb9 to
7e77ea6
Compare
macobo
force-pushed
the
timestamp-idempotency-key
branch
from
7e77ea6 to
2fe3f82
Compare
|
I'm not sure about the failures here: 1.8 failure seems real, no support for this method, but others seem like things that would be failing on master as well. Would it be worth dropping support for 1.8? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues work from #14 and also adds idempotency_key support.