-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Dagu Motor Controller and Fuel Gauge from DSSCircuits #10
base: hydro-devel
Are you sure you want to change the base?
Conversation
If you want more than one Fuel Gauge then you need soft I2C as the address can not change. I may add later.
Only added State of charge and cell voltage. The MAX17043 has a few other functions such as Alert, sleep, quick start, and power on reset.
Also the Dagu code needs the Teensy Encoder library |
@@ -45,6 +45,14 @@ | |||
* POSSIBILITY OF SUCH DAMAGE. | |||
*********************************************************************/ | |||
|
|||
//#define USE_FG //Enable use of Fuel Gauge for LiPo batteries: http://dsscircuits.com/lipo-fuel-gauge.html | |||
#undef USE_FG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there somewhere else this can be accidently be defined? It seems the #undef is unnecessary in my opinion. I would really suggest just having a set of
#define VALUE // COMMENT
//#define VALUE // COMMENT
And you just uncomment the items you want...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah not sure why I did that. I think I had copy and pasted from the servo define.
Also, it seems this entire pull request could be condensed down to a single commit -- there's a lot of individual commits that do not work alone. |
I had deleted my repository and recreated to make sure it was the latest. Then made the changes on github.com. That is why there is so many commits. |
Only using 2 of the 4 Encoders that the Dagu Motor Controller supports. Also setup for 4 wheel motors, but some Rover 5 only have 2.