Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dagu Motor Controller and Fuel Gauge from DSSCircuits #10

Open
wants to merge 6 commits into
base: hydro-devel
Choose a base branch
from

Conversation

FriedCircuits
Copy link

Only using 2 of the 4 Encoders that the Dagu Motor Controller supports. Also setup for 4 wheel motors, but some Rover 5 only have 2.

If you want more than one Fuel Gauge then you need soft I2C as the address can not change. I may add later.
Only added State of charge and cell voltage. The MAX17043 has a few other functions such as Alert, sleep, quick start, and power on reset.
@FriedCircuits
Copy link
Author

Also the Dagu code needs the Teensy Encoder library
http://www.pjrc.com/teensy/td_libs_Encoder.html

@@ -45,6 +45,14 @@
* POSSIBILITY OF SUCH DAMAGE.
*********************************************************************/

//#define USE_FG //Enable use of Fuel Gauge for LiPo batteries: http://dsscircuits.com/lipo-fuel-gauge.html
#undef USE_FG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there somewhere else this can be accidently be defined? It seems the #undef is unnecessary in my opinion. I would really suggest just having a set of

#define VALUE // COMMENT
//#define VALUE // COMMENT

And you just uncomment the items you want...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah not sure why I did that. I think I had copy and pasted from the servo define.

@mikeferguson
Copy link
Member

Also, it seems this entire pull request could be condensed down to a single commit -- there's a lot of individual commits that do not work alone.

@FriedCircuits
Copy link
Author

I had deleted my repository and recreated to make sure it was the latest. Then made the changes on github.com. That is why there is so many commits.

lukeliuli pushed a commit to lukeliuli/ros_arduino_bridge that referenced this pull request May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants