Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support backporting from non-master branches [v/5.3] #1505

Open
wants to merge 1 commit into
base: v/5.3
Choose a base branch
from
Open

Support backporting from non-master branches [v/5.3] #1505

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #1501

Fixes: DOC-370

@github-actions github-actions bot requested a review from oliverhowell January 29, 2025 09:43
@github-actions GitHub Actions
Copy link
Contributor Author

👍 Created #1505 to backport into v/5.3.

@JackPGreen JackPGreen enabled auto-merge (squash) January 29, 2025 09:45
@netlify Netlify
Copy link

netlify bot commented Jan 29, 2025 •
edited
Loading

✅ Deploy Preview for hardcore-allen-f5257d ready!

Name Link
🔨 Latest commit 609dc7c
🔍 Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/6799f84e9edbc000083365e5
😎 Deploy Preview https://deploy-preview-1505--hardcore-allen-f5257d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JackPGreen JackPGreen mentioned this pull request Jan 29, 2025
Merged
JackPGreen added a commit to hazelcast/backport that referenced this pull request Jan 29, 2025
@JackPGreen
Fix backport PR comments (#24)
15c2dd6 
Because the original PR number isn't available, we end up putting
comments on the new backported PR instead when we meant to comment on
the source.


[Example](https://github.com/hazelcast/hz-docs/actions/runs/13028548879/job/36342475892):
```
gh pr comment "" \
   --repo ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY} \
   --body "👍 Created $(gh pr view --json url --jq .url) to backport into [\`v/5.3\`](${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/tree/v/5.3)."
```



[Example](hazelcast/hz-docs#1505 (comment)):
<img width="934" alt="image"
src="https://github.com/user-attachments/assets/4de6c363-5346-4ac1-af84-9b065946cdf3"
/>

This should've gone on the [source
PR](hazelcast/hz-docs#1501).

Tested here
([source](JackPGreen/backport-test#132) +
[backported PRs](JackPGreen/backport-test#133)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverhowell oliverhowell Awaiting requested review from oliverhowell

At least 1 approving review is required to merge this pull request.

Assignees

@JackPGreen JackPGreen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JackPGreen