Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Proof of concept #13

Merged
merged 121 commits into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
121 commits
Select commit Hold shift + click to select a range
cf4046e
add proto submodule
severindellsperger Feb 15, 2024
b6e4679
add initial structure
severindellsperger Feb 15, 2024
27eb1e9
add config handling
severindellsperger Feb 16, 2024
c902d15
add link retrieval and graph handling
severindellsperger Feb 19, 2024
4123a22
first prototype over all layers
severindellsperger Feb 22, 2024
36bb877
change to fetch ls_node from jagw and add support for different weigh…
severindellsperger Mar 12, 2024
6d043c2
implement basic subscription logic
severindellsperger Mar 13, 2024
4189be1
add update handling for nodes and links
severindellsperger Mar 14, 2024
a5d6dec
implement processing of network updates
severindellsperger Mar 19, 2024
0fb2ac7
implement recalculation triggered by network events
severindellsperger Mar 20, 2024
9237e80
implement logic to avoid flapping
severindellsperger Mar 26, 2024
1f2fd07
added latest api files
severindellsperger Apr 12, 2024
b8dc82f
refactor whole project
severindellsperger Apr 17, 2024
e4c71a8
implement low packet loss path computation
severindellsperger Apr 18, 2024
e3bfebb
refactor calculation handling
severindellsperger May 1, 2024
291f506
add max and min priority queue and first implementation of low bandwi…
severindellsperger May 7, 2024
331a555
add utilization intent and optimize update calculation
severindellsperger May 14, 2024
cd0a1d2
adapt to new bandwidth values
severindellsperger May 15, 2024
5500150
add analyze command and add plantuml generation to shortest path test
severindellsperger May 22, 2024
7145ede
add histogram creation to analyze command
severindellsperger May 23, 2024
7086e2b
refactor normalize and analyze package
severindellsperger Jun 7, 2024
299b173
renamed standard normalizer to zscore normalizer
severindellsperger Jun 10, 2024
769a4b1
implement rolling normalization
severindellsperger Jun 10, 2024
acb6c64
adjust calculation in iqr min max normalizer
severindellsperger Jun 13, 2024
67d78c1
update to new jagw version + implement retrieval of normalized factors
severindellsperger Jun 14, 2024
7a4a48e
implement first version of weighted dijkstra with normalized values
severindellsperger Jun 14, 2024
cf2176e
refactor & implement max constraints
severindellsperger Jun 17, 2024
66ff0ce
optimize stream and error handling
severindellsperger Jun 18, 2024
3ea2dfa
implement minimum bandwidth constraint
severindellsperger Jun 18, 2024
10a3de3
unified shortest path calculation and fix grpc context cancelled bug
severindellsperger Jun 19, 2024
40d35fd
adjust to latest jagw version (v1.4.0)
severindellsperger Jun 21, 2024
c3d6ff1
add flex algo intent logic
severindellsperger Jun 22, 2024
b8ec0ff
add logic to add other intents to flex algo
severindellsperger Jun 23, 2024
0c0c078
implement consul service monitoring
severindellsperger Jul 7, 2024
8d55da9
implement service function chaining intent
severindellsperger Jul 8, 2024
d487e7d
refactor helper and processor package
severindellsperger Jul 9, 2024
03d842b
implement proper stop and implement calculation options
severindellsperger Jul 10, 2024
1c7e6c8
refactor calculation manager - add transformer and udpater services
severindellsperger Jul 10, 2024
d1fd27e
test adapter package
severindellsperger Jul 11, 2024
efe6240
merge main
severindellsperger Jul 11, 2024
a11ae60
add test folder
severindellsperger Jul 11, 2024
8e1da43
test adapter and optimize code
severindellsperger Jul 11, 2024
039c771
test in memory cache
severindellsperger Jul 11, 2024
53f5339
add test of RemoveClientNetwork in cache
severindellsperger Jul 11, 2024
3cead3b
test config package
severindellsperger Jul 11, 2024
3257457
improve config tests
severindellsperger Jul 11, 2024
9e701f1
initial test of domain package
severindellsperger Jul 15, 2024
c5fc3a3
optimize domain package tests
severindellsperger Jul 15, 2024
ca8488c
test validation of new path request
severindellsperger Jul 15, 2024
ba5c1d3
test graph package and improve code and tests
severindellsperger Jul 15, 2024
8296474
improve code and tests
severindellsperger Jul 15, 2024
23138d3
add missing test case
severindellsperger Jul 15, 2024
329ee37
finish testing graph package
severindellsperger Jul 15, 2024
ea5b429
refactor code and test session controller
severindellsperger Jul 16, 2024
7069457
add tests for jagw request service
severindellsperger Jul 16, 2024
72b28f7
improve request service code and tests
severindellsperger Jul 16, 2024
c369246
finish request service tests
severindellsperger Jul 16, 2024
dc93fce
improve and test jagw subscription service
severindellsperger Jul 17, 2024
5a2efbc
fix race conditions in subscription service tests
severindellsperger Jul 17, 2024
ed00ce7
improve existing tests and add stop test for subscription service
severindellsperger Jul 17, 2024
8b41461
finish subscription service test
severindellsperger Jul 17, 2024
b6929fc
optimize and test messaging package
severindellsperger Jul 17, 2024
6f74e84
fix race condition in grpc server tests
severindellsperger Jul 17, 2024
08d66f4
finish messaging tests
severindellsperger Jul 17, 2024
c319ac4
add tests for link event processor
severindellsperger Jul 18, 2024
c90596a
finish tests for link event processor
severindellsperger Jul 18, 2024
f8de9df
test network processor
severindellsperger Jul 18, 2024
72bfc33
update network processor tests
severindellsperger Jul 18, 2024
352eebc
optimize tests for network processor
severindellsperger Jul 18, 2024
d39cabb
finish network processor testing
severindellsperger Jul 18, 2024
57d6662
add node event processor tests
severindellsperger Jul 18, 2024
44f72b2
optimize and test prefix event processor
severindellsperger Jul 18, 2024
cb2fb05
test sid event processor
severindellsperger Jul 18, 2024
beb8c2f
improve and test service monitoring
severindellsperger Jul 19, 2024
d5d0bb6
add missing tests for service monitoring
severindellsperger Jul 19, 2024
96db54b
finish service monitoring tests
severindellsperger Jul 19, 2024
cf684a0
fix service monitoring tests
severindellsperger Jul 19, 2024
10dfd73
test calculation manager
severindellsperger Jul 20, 2024
77c062a
test calculation transformer service
severindellsperger Jul 20, 2024
d623f9c
finish testing calculation transformer service
severindellsperger Jul 20, 2024
76ba719
tests and improve priority queue
severindellsperger Jul 20, 2024
116a781
fix calculation bugs, improve code and test setup provider
severindellsperger Jul 21, 2024
32358ca
finish testing calculation setup provider
severindellsperger Jul 21, 2024
426861d
test calculation updater
severindellsperger Jul 21, 2024
8f99a4e
add shortest path calculation tests
severindellsperger Jul 22, 2024
115d0c8
optimize sfc code and test it
severindellsperger Jul 22, 2024
d87532e
add additional tests service function chain calculation
severindellsperger Jul 22, 2024
90c976e
finish sfc calculation tests
severindellsperger Jul 22, 2024
db94dcf
add lint and release workflows
severindellsperger Jul 22, 2024
62eca80
fix lint errors
severindellsperger Jul 22, 2024
60bfb5b
remove docket step from workflow
severindellsperger Jul 22, 2024
35f5b5b
add goreleaser config file
severindellsperger Jul 22, 2024
9cd2ab8
add Dockerfile
severindellsperger Jul 22, 2024
e11bf49
adjust Dockerfile
severindellsperger Jul 22, 2024
30b6fe4
edit docker entrypoint
severindellsperger Jul 22, 2024
2c57d1c
edit Dockerfile content
severindellsperger Jul 22, 2024
481f48e
add CGO_ENABLED=0 to build options
severindellsperger Jul 22, 2024
46ad989
add version command
severindellsperger Jul 30, 2024
a7ab435
optimize min max handling
severindellsperger Aug 6, 2024
c168815
move analyze command to own branch and remove it from poc
severindellsperger Aug 12, 2024
9d82cdd
add deb release
severindellsperger Aug 12, 2024
95481a5
remove check if flags are necessary
severindellsperger Aug 12, 2024
d6cbe19
add skip tls verification env variable
severindellsperger Aug 12, 2024
7208aa7
add initial documentation
severindellsperger Aug 12, 2024
801da83
add code of conduct
severindellsperger Aug 12, 2024
fc49f84
add design documentation
severindellsperger Aug 13, 2024
f23d6c4
add kreya api spec and document low latency intent
severindellsperger Aug 13, 2024
5cb553f
add low jitter and low packet loss documentation
severindellsperger Aug 13, 2024
8a9f612
add bandwidth intents docu
severindellsperger Aug 13, 2024
3e9b50c
add low utilization intent documentation
severindellsperger Aug 13, 2024
b7e259e
add intent combination docu
severindellsperger Aug 14, 2024
f974cd4
correct combined intens docu
severindellsperger Aug 14, 2024
40a312d
add sfc intent docu
severindellsperger Aug 14, 2024
a6fe946
docu flex algo intent and adjust intent overview docu page
severindellsperger Aug 14, 2024
27a7985
optimize dou
severindellsperger Aug 19, 2024
55b3ecd
add docu about tests
severindellsperger Aug 19, 2024
c5e4652
improve calculation docu
severindellsperger Aug 19, 2024
fa52e8f
replace overview picture
severindellsperger Aug 19, 2024
3178d07
replace overview picture
severindellsperger Aug 19, 2024
9189ada
improve sfc douc
severindellsperger Aug 22, 2024
68a64b6
update graph docu and update design picture
severindellsperger Aug 22, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/golangci-lint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Go Checks

on:
pull_request: {}
push:
branches:
- main

jobs:
golangci:
name: lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: '1.21'
cache: false
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.54
44 changes: 44 additions & 0 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
name: Release hawkeye

on:
push:
tags:
- v[0-9]+.*

permissions:
contents: write
packages: write

jobs:
goreleaser:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Set up Go
uses: actions/setup-go@v5
with:
go-version-file: 'go.mod'
cache: true

- name: Load Go Modules
run: go mod tidy

- name: Log into Registry
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Run GoReleaser
uses: goreleaser/goreleaser-action@v5
with:
distribution: goreleaser
version: latest
args: release --clean
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
8 changes: 4 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

# Test binary, built with `go test -c`
*.test
!uml/test

# Output of the go coverage tool, specifically when used with LiteIDE
*.out
Expand All @@ -26,13 +27,12 @@ bin/
# png folder
png/

#
test/uml
# no UML files
*.uml


## VS Code
.vscode/


## Debug
__debug*
__debug*
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "proto"]
path = proto
url = https://github.com/hawkv6/proto
32 changes: 32 additions & 0 deletions .goreleaser.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
project_name: hawkeye

before:
hooks:
- go mod tidy

builds:
- main: ./hawkeye/
binary: hawkeye
ldflags:
- -s -w -X main.build={{.Version}}
goos:
- linux
goarch:
- amd64
env:
- CGO_ENABLED=0

dockers:
- use: buildx
dockerfile: ./build/package/Dockerfile
image_templates:
- "ghcr.io/hawkv6/hawkeye:latest"
- "ghcr.io/hawkv6/hawkeye:{{ .Tag }}"

nfpms:
- maintainer: Severin Dellsperger <[email protected]>
description: Controller for Enabling Intent-Based Networking in SRv6
homepage: https://github.com/hawkv6/hawkeye
license: Apache 2.0
formats:
- deb
128 changes: 128 additions & 0 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
# Contributor Covenant Code of Conduct

## Our Pledge

We as members, contributors, and leaders pledge to make participation in our
community a harassment-free experience for everyone, regardless of age, body
size, visible or invisible disability, ethnicity, sex characteristics, gender
identity and expression, level of experience, education, socio-economic status,
nationality, personal appearance, race, religion, or sexual identity
and orientation.

We pledge to act and interact in ways that contribute to an open, welcoming,
diverse, inclusive, and healthy community.

## Our Standards

Examples of behavior that contributes to a positive environment for our
community include:

* Demonstrating empathy and kindness toward other people
* Being respectful of differing opinions, viewpoints, and experiences
* Giving and gracefully accepting constructive feedback
* Accepting responsibility and apologizing to those affected by our mistakes,
and learning from the experience
* Focusing on what is best not just for us as individuals, but for the
overall community

Examples of unacceptable behavior include:

* The use of sexualized language or imagery, and sexual attention or
advances of any kind
* Trolling, insulting or derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or email
address, without their explicit permission
* Other conduct which could reasonably be considered inappropriate in a
professional setting

## Enforcement Responsibilities

Community leaders are responsible for clarifying and enforcing our standards of
acceptable behavior and will take appropriate and fair corrective action in
response to any behavior that they deem inappropriate, threatening, offensive,
or harmful.

Community leaders have the right and responsibility to remove, edit, or reject
comments, commits, code, wiki edits, issues, and other contributions that are
not aligned to this Code of Conduct, and will communicate reasons for moderation
decisions when appropriate.

## Scope

This Code of Conduct applies within all community spaces, and also applies when
an individual is officially representing the community in public spaces.
Examples of representing our community include using an official e-mail address,
posting via an official social media account, or acting as an appointed
representative at an online or offline event.

## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported to the community leaders responsible for enforcement at
[email protected].
All complaints will be reviewed and investigated promptly and fairly.

All community leaders are obligated to respect the privacy and security of the
reporter of any incident.

## Enforcement Guidelines

Community leaders will follow these Community Impact Guidelines in determining
the consequences for any action they deem in violation of this Code of Conduct:

### 1. Correction

**Community Impact**: Use of inappropriate language or other behavior deemed
unprofessional or unwelcome in the community.

**Consequence**: A private, written warning from community leaders, providing
clarity around the nature of the violation and an explanation of why the
behavior was inappropriate. A public apology may be requested.

### 2. Warning

**Community Impact**: A violation through a single incident or series
of actions.

**Consequence**: A warning with consequences for continued behavior. No
interaction with the people involved, including unsolicited interaction with
those enforcing the Code of Conduct, for a specified period of time. This
includes avoiding interactions in community spaces as well as external channels
like social media. Violating these terms may lead to a temporary or
permanent ban.

### 3. Temporary Ban

**Community Impact**: A serious violation of community standards, including
sustained inappropriate behavior.

**Consequence**: A temporary ban from any sort of interaction or public
communication with the community for a specified period of time. No public or
private interaction with the people involved, including unsolicited interaction
with those enforcing the Code of Conduct, is allowed during this period.
Violating these terms may lead to a permanent ban.

### 4. Permanent Ban

**Community Impact**: Demonstrating a pattern of violation of community
standards, including sustained inappropriate behavior, harassment of an
individual, or aggression toward or disparagement of classes of individuals.

**Consequence**: A permanent ban from any sort of public interaction within
the community.

## Attribution

This Code of Conduct is adapted from the [Contributor Covenant][homepage],
version 2.0, available at
https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.

Community Impact Guidelines were inspired by [Mozilla's code of conduct
enforcement ladder](https://github.com/mozilla/diversity).

[homepage]: https://www.contributor-covenant.org

For answers to common questions about this code of conduct, see the FAQ at
https://www.contributor-covenant.org/faq. Translations are available at
https://www.contributor-covenant.org/translations.
31 changes: 31 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
.PHONY: proto

GREEN := $(shell tput -Txterm setaf 2)
YELLOW := $(shell tput -Txterm setaf 3)
WHITE := $(shell tput -Txterm setaf 7)
CYAN := $(shell tput -Txterm setaf 6)
RESET := $(shell tput -Txterm sgr0)

help:
@echo ''
@echo 'Usage:'
@echo ' ${YELLOW}make${RESET} ${GREEN}<target>${RESET}'
@echo ''
@echo 'Targets:'
@awk 'BEGIN {FS = ":.*?## "} { \
if (/^[a-zA-Z_0-9-]+:.*?##.*$$/) {printf " ${YELLOW}%-20s${GREEN}%s${RESET}\n", $$1, $$2} \
else if (/^## .*$$/) {printf " ${CYAN}%s${RESET}\n", substr($$1,4)} \
}' $(MAKEFILE_LIST)

update-submodules: ## Update submodules (sync proto)
git submodule update --remote --merge

binary: ## Build binary bin/hawkeye
mkdir -p bin
go build -o bin/hawkeye hawkeye/main.go

clean: ## Clean bin directory
rm -rf bin

proto: ## Generate Go code from proto files
protoc --go_out=. --go_opt=Mproto/intent.proto=pkg/api --go-grpc_out=. --go-grpc_opt=Mproto/intent.proto=pkg/api proto/*.proto --experimental_allow_proto3_optional
98 changes: 96 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,96 @@
# hawkeye
Controller for Enabling Intent-Driven End-to-End SRv6 Networking
<h1 align="center">HawkEye</h1>
<p align="center">
<br>
<img alt="GitHub Release" src="https://img.shields.io/github/v/release/hawkv6/hawkeye?display_name=release&style=flat-square">
<img src="https://img.shields.io/badge/go%20report-A+-brightgreen.svg?style=flat-square">
<img src="https://img.shields.io/github/actions/workflow/status/hawkv6/hawkeye/testing.yaml?style=flat-square&label=tests">
<img src="https://img.shields.io/codecov/c/github/hawkv6/hawkeye?style=flat-square">
<img src="https://img.shields.io/github/actions/workflow/status/hawkv6/hawkeye/golangci-lint.yaml?style=flat-square&label=checks">
</p>

<p align="center">
</p>


## Overview
HawkEye is an advanced controller designed to facilitate Intent-Based Networking (IBN) and Segment Routing over IPv6 (SRv6). It integrates with open-source projects like [Jalapeno](https://github.com/cisco-open/jalapeno) and the [Jalapeno API Gateway](https://github.com/jalapeno-api-gateway), and utilizes standardized protocols such as [BMP](https://datatracker.ietf.org/doc/rfc7854/) and [YANG-Push](https://datatracker.ietf.org/doc/rfc8641/). Additionally, HawkEye leverages [Consul](https://www.consul.io/) as a service registry to gather critical information about network services and perform health checks.

When receiving path requests from clients via gRPC, HawkEye calculates optimal paths based on the specified intents and maps these paths to segment lists, which are then returned to the clients for packet encapsulation. The application continuously monitors the network, adjusting paths as network conditions evolve. If a change is necessary to maintain the intent, an updated segment list is automatically provided to the client, ensuring that the network meets the desired requirements.

![HawkEye Architecture](docs/images/Hawkv6-High-Level-Architecture.drawio.svg)

## Key Features

- **Intent Fulfillment**: HawkEye processes user-defined intents, such as ensuring low latency, high bandwidth, or specific service function chaining, and calculates optimal paths in the SRv6 network to meet these requirements. It returns the segment list that must be applied to the packet to achieve the desired behavior.

- **Real-Time Network Monitoring**: HawkEye continuously monitors network performance metrics, including latency, jitter, and packet loss. It responds to network changes such as link removals or performance metric variations, ensuring that the network adheres to the specified intents. This task leverages components like [Jalapeno](https://github.com/cisco-open/jalapeno), [JAGW](https://github.com/jalapeno-api-gateway), [Consul](https://www.consul.io/), the [generic-processor](https://github.com/hawkv6/generic-processor), and the [clab-telemetry-linker](https://github.com/hawkv6/clab-telemetry-linker).

- **Event-Driven Architecture**: HawkEye operates in an event-driven manner, automatically recalculating paths and updating segment lists when network conditions change or when service health checks indicate issues. Operators can define thresholds that determine when a path should be switched, preventing unnecessary path flapping. This feature ensures that the network remains responsive and reliable.

- **Service Registry Integration**: HawkEye integrates with [Consul](https://www.consul.io/) to monitor service availability and health. This integration ensures that service function chaining remains intact and that paths are adjusted if a service instance becomes unavailable.

- **Session Management**: HawkEye tracks ongoing sessions for each client, maintaining a record of path requests and updates. This session management capability allows for seamless adjustments to paths as network conditions change, ensuring continuous intent compliance.

- **Interoperability**: HawkEye leverages standardized technologies like YANG-Push for telemetry and BMP for performance measurement, ensuring compatibility with existing network hardware and software.

## Design Considerations

The design principles and detailed information about the HawkEye implementation are available in the [design documentation](docs/design.md).


## Intent Overview
An overview about the intents and examples can be found in the [intent documentation](docs/intents/overview.md).


## Usage
```
hawkeye [command]
```
### Commands
- Start the controller: [`start`](docs/commands/start.md)
- Check Version: `version`

## Installation

### Using Package Manager
For Debian-based systems, install the package using apt:
```
sudo apt install ./hawkeye_{version}_amd64.deb
```

### Using Docker
```
docker run --rm -e HAWKEYE_JAGW_SERVICE_ADDRESS=10.8.39.69 -e HAWKEYE_JAGW_REQUEST_PORT=9903 -e HAWKEYE_JAGW_SUBSCRIPTION_PORT=9902 -e HAWKEYE_GRPC_PORT=10000 -e HAWKEYE_CONSUL_SERVER_ADDRESS=consul-hawkv6.stud.network.garden -e HAWKEYE_SKIP_TLS_VERIFICATION=TRUE ghcr.io/hawkv6/hawkeye:latest start
```

### Using Binary
```
git clone https://github.com/hawkv6/hawkeye
cd hawkeye && make binary
sudo ./bin/hawkeye
```

## Getting Started

1. Deploy all necessary Kubernetes resources.
- For more details, refer to the [hawkv6 deployment documentation](https://github.com/hawkv6/deployment).

2. Ensure the network is properly configured and operational.
- Additional information can be found in the [hawkv6 testnetwork documentation](https://github.com/hawkv6/network).

3. Confirm that `clab-telemetry-linker` is active and running.
- Detailed instructions are available in the [clab-telemetry-linker documentation](https://github.com/hawkv6/clab-telemetry-linker).

4. Confirm that the `generic-processor` is active and running.
- Detailed instructions are available in the [generic processor documentation](https://github.com/hawkv6/generic-processor).

5. Install the HawkEye controller using one of the methods described above.

5. Start the HawkEye controller.
- For more information, refer to the [start command documentation](docs/commands/start.md).

## Additional Information
- Environment variables are documented in the [env documentation](docs/env.md).
- The proto/API definiton is included via submodule and can be found [here](https://github.com/hawkv6/proto/blob/main/intent.proto).
- Limitations are documented in the [limitations documentation](docs/limitations.md).
- Unit tests are documented in the [unit tests documentation](docs/unit-tests.md).
Loading
Loading