Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): prepare testing setup for http2 and https #190

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

cyco130
Copy link
Member

@cyco130 cyco130 commented Dec 1, 2024

This PR adds alternative fetch implementations to be used for testing HTTPS and HTTP/2 adapters. It also adds a few lines to make the standard Node adapter work with node:http2 correctly (except for the types).

This should allow testing #185 as well. I've already added an HTTP/2 test (using the standard Node adapter). The types don't match but all tests are passing. It might still take some work to make sure everything works as expected though.

Also added node:https and "uwebsockets.js with SSL" tests.

Copy link
Contributor

@aleclarson aleclarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool!

@cyco130
Copy link
Member Author

cyco130 commented Dec 1, 2024

Looks like Windows can't cleanly close the HTTP/2 connection and Node 18 seems picky about uwebSocket's SSL implementation too. Let's try to address those one by one 😅

@cyco130 cyco130 force-pushed the chore/http2-tests branch 3 times, most recently from e6e0234 to 6a7669d Compare December 1, 2024 15:42
@cyco130
Copy link
Member Author

cyco130 commented Dec 1, 2024

I disabled "uwebSockets.js with SSL" tests on Node 18. We only support Node 18 for StackBlitz and StackBlitz will switch to v20 soon. And it can't run uwebSockets.js anyway. No need to spend more time on it.

I opened a separate issue for the Windows failure. I don't have a Windows machine and it's almost impossible for me to investigate. Also, I have a suspicion that it is related to my fetch implementation rather than the adapter. No need to block this as we're not breaking anything that wasn't already broken.

@cyco130 cyco130 merged commit 1e816c2 into main Dec 1, 2024
6 checks passed
@cyco130 cyco130 deleted the chore/http2-tests branch December 1, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants