Prevent macos crash on high concurrecy #385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntharo
reviewed
Jan 26, 2024
Comment on lines
-274
to
-276
| // TODO: Allow the connect timeout to be configured | ||
| let timeout_duration = tokio::time::Duration::from_secs(5); | ||
|
|
There was a problem hiding this comment.
Are we sure that a connection timeout is what is causing the crash?
It might be handling of errors after the timeouts that cause the crash or some of the other changes here.
I'd really suggest keeping the timeout if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP fix #384
I don't know why. This patch reduce the probability of crach on MacOS.