Add query metrics and spans #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljharvey
commented
Nov 15, 2023
| @@ -155,39 +156,7 @@ impl connector::Connector for SQLServer { | |||
| state: &Self::State, | |||
| query_request: models::QueryRequest, | |||
| ) -> Result<JsonResponse<models::QueryResponse>, connector::QueryError> { | |||
| tracing::info!("{}", serde_json::to_string(&query_request).unwrap()); | |||
There was a problem hiding this comment.
Moved to src/query.rs
danieljharvey
commented
Nov 15, 2023
| @@ -1,58 +0,0 @@ | |||
| //! Metrics setup and update for our connector. | |||
There was a problem hiding this comment.
Superceded by metrics.rs in query-engine
danieljharvey
commented
Nov 15, 2023
| /// | ||
| /// This function implements the [query endpoint](https://hasura.github.io/ndc-spec/specification/queries/index.html) | ||
| /// from the NDC specification. | ||
| pub async fn query( |
There was a problem hiding this comment.
Split this up into plan_query and execute_query so it's easier to time / instrument both.
danieljharvey
commented
Nov 15, 2023
| Ok(response) | ||
| } | ||
|
|
||
| async fn execute_query( |
There was a problem hiding this comment.
Make execute_query it's own function so it's easier to instrument / time.
danieljharvey
commented
Nov 15, 2023
| @@ -21,35 +24,57 @@ pub async fn mssql_execute( | |||
| &plan.variables, | |||
| ); | |||
|
|
|||
| let acquisition_timer = metrics.time_connection_acquisition_wait(); | |||
| let connection_result = mssql_pool | |||
There was a problem hiding this comment.
Acquire one connection and use it throughout rather than passing the pool around.
danieljharvey
force-pushed
the
djh/NDAT-1031/add-metrics
branch
from
5866d79 to
07614ce
Compare
danieljharvey
commented
Nov 15, 2023
| @@ -0,0 +1,12 @@ | |||
| apiVersion: 1 | |||
There was a problem hiding this comment.
Everything in /metrics is taken from ndc-postgres and postgres -> sqlserver.
danieljharvey
force-pushed
the
djh/NDAT-1031/add-metrics
branch
from
965a7c5 to
c12eef1
Compare
Merged
soupi
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In order to run the benchmarks we rely on a bunch of metrics existing, such as connection acquisition time and query time. This adds these, as well as instrumenting OTel spans in this area too.
How
Match
ndc-postgresas much as possible.