"Introspect" basic comparison operators #64
Merged
+3,017
−2,587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljharvey
changed the title
danieljharvey
commented
Nov 13, 2023
| @@ -0,0 +1,71 @@ | |||
| use std::fs; | |||
There was a problem hiding this comment.
The test that makes sure the static deployment in the repo is up to date with the code.
danieljharvey
commented
Nov 13, 2023
| @@ -0,0 +1,1746 @@ | |||
| { | |||
There was a problem hiding this comment.
We've added the "save all old versions of these files" script so we can add the "make sure we can parse all the old versions" test soon.
danieljharvey
commented
Nov 13, 2023
| @@ -0,0 +1,21 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Everything in /scripts is taken pretty much verbatim from ndc-postgres.
plcplc
reviewed
Nov 13, 2023
plcplc
approved these changes
Nov 13, 2023
| mkdir -p "$SNAPSHOT_DIR" | ||
|
|
||
| # create filename from hash of contents | ||
| NEW_FILENAME="$(sha256sum "${CHINOOK_DEPLOYMENT}" | cut -f1 -d' ').json" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We've been relying on hardcoded introspection information taken from
ndc-postgres, but that's not really very useful.This implements somewhat hard coded introspection for comparison operators using info from the SQLServer websites.
How
just generate-chinook-configuration