Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use sqlcmd in docker #62

Merged
merged 1 commit into from
Nov 9, 2023
Merged

use sqlcmd in docker #62

merged 1 commit into from
Nov 9, 2023

Conversation

soupi
Copy link
Contributor

@soupi soupi commented Nov 9, 2023

What

I don't have sqlcmd installed, and we are using the mssql server docker image which contain sqlcmd, and not the azure one. So we can call sqlcmd inside docker instead?

I had to mount static/ to do that, and I moved the temp file there as well if that's alright.

danieljharvey
danieljharvey approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@danieljharvey danieljharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh this is nice. Much nicer than depending on whatever is laying around. Thanks!

@danieljharvey danieljharvey added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit 359eb9a Nov 9, 2023
6 checks passed
@SamirTalwar SamirTalwar deleted the gil/use-sqlcmd-in-docker branch November 20, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljharvey danieljharvey danieljharvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soupi @danieljharvey