Use ndc-postgres query engine
#57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljharvey
force-pushed
the
djh/copy-pasta-postgres-query-engine
branch
from
c6eb17a to
252206c
Compare
plcplc
approved these changes
Nov 6, 2023
crates/query-engine/translation/src/translation/query/operators.rs
Outdated
Show resolved
Hide resolved
| configuration: &DeploymentConfiguration, | ||
| ) -> Result<DeploymentConfiguration, connector::ValidateError> { | ||
| if configuration.version != 1 { | ||
| config: DeploymentConfiguration, |
There was a problem hiding this comment.
I take it that the current Sql Server implementation does not include any introspection and just relies on the deployment files from Postgres for e.g tests etc?
If it did have an introspection ability that would have to updated substantially as well with this new change dump.
There was a problem hiding this comment.
100% - once introspection goes in I guess these types will change a bunch.
…s.rs Co-authored-by: Philip Lykke Carlsen <[email protected]>
danieljharvey
commented
Nov 7, 2023
Co-authored-by: Philip Lykke Carlsen <[email protected]>
Co-authored-by: Philip Lykke Carlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ndc-postgreshas changed a bunch since we forked from it. This grabs thendc-postgresquery engine, and then fixes it for SQLServer again. All the existing tests pass, there are probably new ones we can add as we check new functionality such as Native Queries.How
Copy and paste and then fix things.
Minimal changes were made in the
ndc-sqlservercrate, only enough to get everything working