Fix EXISTS tests

crates/ndc-sqlserver/tests/goldenfiles/select_where_related_exists.json

@@ -38,7 +38,7 @@
         },
         "operator": {
           "type": "other",
-          "name": "like"
+          "name": "_like"
         },
         "value": {
           "type": "scalar",

crates/ndc-sqlserver/tests/query_tests.rs

@@ -96,7 +96,6 @@ mod predicates {
         insta::assert_json_snapshot!(result);
     }
 
-    /*
     // fix exists implementation
     #[tokio::test]
     async fn select_where_unrelated_exists() {
@@ -110,7 +109,6 @@ mod predicates {
         let result = run_query("select_where_related_exists").await;
         insta::assert_json_snapshot!(result);
     }
-    */
 }
 
 mod sorting {

crates/ndc-sqlserver/tests/snapshots/query_tests__predicates__select_where_related_exists.snap

@@ -6,6 +6,7 @@ expression: result
   {
     "rows": [
       {
+        "title": "Santana",
         "albums": {
           "rows": [
             {
@@ -18,8 +19,7 @@ expression: result
               "title": "Santana Live"
             }
           ]
-        },
-        "title": "Santana"
+        }
       }
     ]
   }

crates/query-engine/sql/src/sql/convert.rs

@@ -191,7 +191,7 @@ impl Join {
                 sql.append_syntax(")");
                 sql.append_syntax(" AS ");
                 join.alias.to_sql(sql);
-                sql.append_syntax(" ON ('true') ");
+                sql.append_syntax(" ON (1 = 1) ");
             }
             Join::CrossJoin(join) => {
                 sql.append_syntax(" CROSS JOIN ");
@@ -411,8 +411,8 @@ impl Value {
             Value::Character(s) => sql.append_param(Param::String(s.clone())),
             Value::String(s) => sql.append_param(Param::String(s.clone())),
             Value::Variable(v) => sql.append_param(Param::Variable(v.clone())),
-            Value::Bool(true) => sql.append_syntax("true"),
-            Value::Bool(false) => sql.append_syntax("false"),
+            Value::Bool(true) => sql.append_syntax("1 = 1"),
+            Value::Bool(false) => sql.append_syntax("1 = 0"),
             Value::Null => sql.append_syntax("null"),
             Value::Array(items) => {
                 sql.append_syntax("ARRAY [");

crates/query-engine/translation/tests/snapshots/tests__it_select_where_unrelated_exists.snap

@@ -19,7 +19,7 @@ FROM
         WHERE
           (
             (
-              true
+              1 = 1
               AND ([1_artist].[Name] = cast(@P1 as varchar))
             )
             AND ([0_album].[ArtistId] = [1_artist].[ArtistId])

crates/query-engine/translation/tests/snapshots/tests__select_where_album_id_equals_self_nested_object_relationship.snap

@@ -58,7 +58,7 @@ FROM
               [0_Track].[AlbumId] = [9_BOOLEXP_Album].[AlbumId]
             )
           )
-      ) AS [9_BOOLEXP_Album] ON ('true')
+      ) AS [9_BOOLEXP_Album] ON (1 = 1)
       INNER JOIN (
         SELECT
           *
@@ -73,7 +73,7 @@ FROM
               [0_Track].[AlbumId] = [10_BOOLEXP_Album].[AlbumId]
             )
           )
-      ) AS [10_BOOLEXP_Album] ON ('true')
+      ) AS [10_BOOLEXP_Album] ON (1 = 1)
       INNER JOIN (
         SELECT
           *
@@ -88,7 +88,7 @@ FROM
               [10_BOOLEXP_Album].[ArtistId] = [11_BOOLEXP_Artist].[ArtistId]
             )
           )
-      ) AS [11_BOOLEXP_Artist] ON ('true')
+      ) AS [11_BOOLEXP_Artist] ON (1 = 1)
     WHERE
       (
         [9_BOOLEXP_Album].[AlbumId] > [11_BOOLEXP_Artist].[ArtistId]

crates/query-engine/translation/tests/snapshots/tests__select_where_array_relationship.snap

@@ -38,7 +38,7 @@ FROM
           (
             [0_Artist].[ArtistId] = [5_BOOLEXP_Album].[ArtistId]
           )
-      ) AS [5_BOOLEXP_Album] ON ('true')
+      ) AS [5_BOOLEXP_Album] ON (1 = 1)
     WHERE
       (
         [5_BOOLEXP_Album].[Title] LIKE cast(@P1 as varchar)