Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Docker Compose watch item to the connector metadata. #360

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

SamirTalwar
Copy link
Contributor

What

This teaches the DDN CLI that the configuration should be synced, and the connector container restarted, whenever the configuration changes.

How

When emitting connector metadata, we include a dockerComposeWatch item.

This teaches the DDN CLI that the configuration should be synced, and
the connector container restarted, whenever the configuration changes.
@SamirTalwar SamirTalwar requested review from SandeepSamba and a team March 11, 2024 15:33
Copy link
Contributor

@soupi soupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link

@SandeepSamba SandeepSamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@SamirTalwar SamirTalwar enabled auto-merge March 14, 2024 10:21
@SamirTalwar SamirTalwar added this pull request to the merge queue Mar 14, 2024
Merged via the queue into main with commit 591ef96 Mar 14, 2024
35 checks passed
@SamirTalwar SamirTalwar deleted the samirtalwar/cli/docker-compose-watch branch March 14, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants