Enable all Clippy warnings in Cargo.toml. #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means we can just enable them in one place. I have also added `--deny=clippy::all` to the Justfile so it fails if there are any warnings, just like CI does.
soupi
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enabling the warnings in Cargo.toml means tooling (e.g.
cargo clippyandrust-analyzer) will share the same list of warnings.How
Rust v1.74 added support for a
[lints]section in Cargo.toml files.I have also added
--deny=clippy::allto the Justfile so it fails if there are any warnings, just like CI does. This won't scale if we add more warnings though; not sure how to fix that yet.