Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move variables_table to Env #262

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Move variables_table to Env #262

merged 1 commit into from
Jan 17, 2024

Conversation

plcplc
Copy link
Contributor

@plcplc plcplc commented Jan 17, 2024

What

Since the table reference that binds the variables table cannot change in the course of query translation we move this to Env instead of State.

@plcplc plcplc requested review from SamirTalwar and soupi January 17, 2024 15:47
SamirTalwar
SamirTalwar approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@SamirTalwar SamirTalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me.

@plcplc plcplc added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit 9e0a2b4 Jan 17, 2024
26 checks passed
@plcplc plcplc deleted the plc/tidy-up-state-use-variables-table branch January 17, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamirTalwar SamirTalwar SamirTalwar approved these changes

@soupi soupi Awaiting requested review from soupi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plcplc @SamirTalwar