Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive Copy for IsolationLevel so we don't have to clone it. #258

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Derive Copy for IsolationLevel so we don't have to clone it. #258

merged 1 commit into from
Jan 16, 2024

Conversation

SamirTalwar
Copy link
Contributor

What

Just making the code more Rust-y.

It's a little thing but it got in my way earlier.

How

By adding Copy to IsolationLevel, we can freely pass it around by value, not by reference.

soupi
soupi approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@soupi soupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

@SamirTalwar SamirTalwar added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit eb9ab09 Jan 16, 2024
26 checks passed
@SamirTalwar SamirTalwar deleted the samirtalwar/copy-isolation-level branch January 16, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soupi soupi soupi approved these changes

@plcplc plcplc Awaiting requested review from plcplc

@i-am-tom i-am-tom Awaiting requested review from i-am-tom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamirTalwar @soupi