introspect columns to include default, generated and identity columns #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plcplc
reviewed
Jan 16, 2024
| #[serde(default)] | ||
| pub description: Option<String>, | ||
| } | ||
|
|
||
| fn does_not_have_default(has_default: &HasDefault) -> bool { | ||
| matches!(has_default, HasDefault::NoDefault) |
There was a problem hiding this comment.
It was a clippy suggestion :)
plcplc
reviewed
Jan 16, 2024
Comment on lines
+113
to
+115
| -- skipped because yugabyte is based on pg11 that does not have this field. | ||
| -- CASE WHEN att.attgenerated = 's' THEN 'isGenerated' ELSE 'notGenerated' END | ||
| -- AS is_generated |
There was a problem hiding this comment.
There is a trick being employed in pg_table_metadata.sql of HGE v2 which deals with this very issue. It could well be worth it to port that over.
There was a problem hiding this comment.
Ah good to know, for reference: https://github.com/hasura/graphql-engine/blob/master/server/src-rsr/pg_table_metadata.sql#L70-75
Will do that in a follow-up PR.
plcplc
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In order to generate insert mutations we'd like to know which columns should be inserted into, which we shouldn't insert to, and which can go either way.
To do that we add settings for default, generated, and identity information to column information, as well as introspection code.
How
ColumnInfometadatapg_attribute, but see the comment about generated columns