Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate short hash for e2e trigger directly with git #123

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

danieljharvey
Copy link
Contributor

@danieljharvey danieljharvey commented Nov 1, 2023

What

The generated hashes from short-sha did not always match the Docker image. This is because Github Actions creates a new merge commit for pull requests: https://github.com/orgs/community/discussions/26325

How

Find the actual source commit and create a hash from that.

@danieljharvey danieljharvey marked this pull request as ready for review November 1, 2023 09:11
@danieljharvey danieljharvey force-pushed the djh/generate-hash-with-git branch from ba90ef3 to b63f6b1 Compare November 1, 2023 10:42
@danieljharvey danieljharvey requested a review from soupi November 1, 2023 10:42
Copy link
Contributor

@soupi soupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you kind sir

@danieljharvey danieljharvey added this pull request to the merge queue Nov 1, 2023
Merged via the queue into main with commit a0a3248 Nov 1, 2023
@danieljharvey danieljharvey deleted the djh/generate-hash-with-git branch November 1, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants