Run E2E tests on every push/PR in this repo #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-am-tom
force-pushed
the
i-am-tom/e2e-magic
branch
from
ec90793 to
d1a714d
Compare
i-am-tom
force-pushed
the
i-am-tom/e2e-magic
branch
from
67983cd to
ae56d3e
Compare
danieljharvey
approved these changes
Oct 31, 2023
soupi
reviewed
Nov 1, 2023
Comment on lines
+4
to
+6
| merge_group: | ||
| push: | ||
| pull_request: |
There was a problem hiding this comment.
This means that the job runs twice on each commit?
There was a problem hiding this comment.
Pretty much; there's no way to tell GitHub "push xor pull_request".
There was a problem hiding this comment.
I guess could make it only work on pushes to main, then it'd only run double on those.
There was a problem hiding this comment.
FWIW I like it that I can push a branch and have all tests run without having to open a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run the E2E suite using the PR's version of the connector, and make sure all the tests pass. If they do, this PR is compatible with current head. How exciting!