Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix _rootPath in initializeParams #573

Merged
merged 3 commits into from
May 16, 2024
Merged

fix _rootPath in initializeParams #573

merged 3 commits into from
May 16, 2024

Conversation

soulomoon
Copy link
Collaborator

No description provided.

@soulomoon
Copy link
Collaborator Author

It seems we have mixed _locale and _rootPath

michaelpj
michaelpj approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If you feel like it, you could convert this to use record construction syntax so we don't make this mistake again!

@soulomoon
Copy link
Collaborator Author

Yep, that is better

@michaelpj
Copy link
Collaborator

Needs formatting

@soulomoon soulomoon enabled auto-merge (squash) May 16, 2024 14:46
@soulomoon soulomoon merged commit 85a9565 into haskell:master May 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soulomoon @michaelpj