Drop read thread #172
Draft
Drop read thread #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would read events from the console in a separate thread which would be killed after the needed event was read. There are a few issues with this approach: * it is expensive, requiring the creation and destruction of a thread with every read event * it is racy, since the thread may be killed after an even has been read from the console but before it has been pushed to the event TChan * we may read too much: the read loop thread may read more input than Haskeline was supposed to read (see GHC #21047).
bgamari
force-pushed
the
drop-read-thread
branch
from
7a8f1f9 to
a1345a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would read events from the console in a separate thread
which would be killed after the needed event was read. There are a few
issues with this approach:
with every read event
read from the console but before it has been pushed to the event
TChan
Haskeline was supposed to read (see GHC #21047).