Support flushing command history #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously command history was only flushed after the end of session, this commit adds flushHistory function which performs the flushing and a flag to enforce flushing after every command.
Previously command history was only flushed after the end of session, this commit adds flushHistory function which performs the flushing and a flag to Prefs to enforce flushing after every command.
|
@414owen hey, sorry for disappearing, happy for you to pick it up! |
|
👋 @judah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't look like #36 will be updated, I'm happy to pick up where that PR left off.
Changes:
incAppendHistory(based on ZSH'sINC_APPEND_HISTORY)Regressions:
In order to append to history file, items are now written in the order they were entered. This is the opposite of the previous behavior, so when applications upgrade, their history up to that point will be in reverse order.