Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFData1,NFData2 instances (#767) #992

Merged
merged 1 commit into from
Jan 4, 2025
Merged

NFData1,NFData2 instances (#767) #992

merged 1 commit into from
Jan 4, 2025
+75 −6

Conversation

dbeacham
Copy link
Contributor

@dbeacham dbeacham commented Feb 20, 2024 •
edited by meooow25
Loading

I've added NFData1 and NFData2 instances where appropriate for Data.Graph, Data.IntMap, Data.IntSet, Data.Map, Data.Sequence, Data.Set, Data.Tree and relevant internal dependencies

TODO:

  • Check build across GHC versions
  • Add @since docs

Closes #767.

@meooow25
Copy link
Contributor

meooow25 commented Aug 2, 2024

This would be good to have. @dbeacham would you like to finish this PR?

@dbeacham
Copy link
Contributor Author

dbeacham commented Aug 2, 2024

Happy to - I'll finish it up next week.

@dbeacham dbeacham force-pushed the nfdata1-nfdata2-instances branch 2 times, most recently from 83e4566 to 57cc685 Compare August 20, 2024 12:10
@dbeacham dbeacham force-pushed the nfdata1-nfdata2-instances branch 2 times, most recently from cdb3a07 to 6ef991c Compare August 20, 2024 13:59
meooow25
meooow25 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@meooow25 meooow25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could try the foldMap thing if you like, if not this looks good to me.

containers/changelog.md Outdated Show resolved Hide resolved
@treeowl
Copy link
Contributor

treeowl commented Aug 22, 2024

Speaking of changes, we usually use @since TODO because we don't usually know what the actual next version number will be very far in advance. But if @meooow25 wants to make a release imminently, this could be fine.

@meooow25 meooow25 mentioned this pull request Oct 31, 2024
Open
9 tasks
@meooow25
Copy link
Contributor

@dbeacham could you please correct the changelog so we can merge this? Also it needs a rebase.

@dbeacham dbeacham force-pushed the nfdata1-nfdata2-instances branch from 6ef991c to a014c1d Compare November 17, 2024 20:52
@dbeacham
Copy link
Contributor Author

That's done. I left the @since as it was but could update that as well if desired.

@meooow25
Copy link
Contributor

There's a conflict preventing merge, please rebase on latest master.

@meooow25 meooow25 force-pushed the nfdata1-nfdata2-instances branch from a014c1d to 603eaf3 Compare January 1, 2025 15:44
@meooow25 meooow25 mentioned this pull request Jan 1, 2025
Closed
@meooow25
Copy link
Contributor

meooow25 commented Jan 1, 2025

I did the rebase, but we need NFData1 and NFData2 in MicroHs. Opened an issue for it.

@meooow25 meooow25 force-pushed the nfdata1-nfdata2-instances branch from 603eaf3 to 0aec0a7 Compare January 4, 2025 12:03
@meooow25 meooow25 merged commit dcafd78 into haskell:master Jan 4, 2025
13 checks passed
@meooow25
Copy link
Contributor

meooow25 commented Jan 4, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treeowl treeowl treeowl left review comments

@meooow25 meooow25 meooow25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instances for NFData1 and NFData2
3 participants
@dbeacham @meooow25 @treeowl