Use data-default instead of data-default-class #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kokobd Hi, thanks for the PR. Yes please a move to |
kokobd
changed the title
|
I modified this PR to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple version bump to make
servant-auth-servercompatible withdata-default-class 0.2.0.0.I noticed that both
data-defaultanddata-default-classare used in this repo. I wonder if there is plan to move todata-defaultfor all servant packages, like many other packages on Hackage? For exampletlsandcrypton-connectionhave recently moved todata-default.I'm happy to update the PR to use
data-defaultinstead if that's desired.