Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChangeLog updates, remote version bump #77

Merged
merged 6 commits into from
Nov 29, 2020
Merged

ChangeLog updates, remote version bump #77

merged 6 commits into from
Nov 29, 2020

Conversation

sorki
Copy link
Member

@sorki sorki commented Nov 16, 2020

Related to #76

  • few other bits, contentAddressableAddressBuilder changed to reflect contentA...Parser change.

bqv
bqv approved these changes Nov 25, 2020
View reviewed changes
Copy link

@bqv bqv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I qualify but... here have this

@bqv
Copy link

bqv commented Nov 25, 2020

Paging @layus

layus
layus approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@layus layus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for preparing the release :-)

@bqv
Copy link

bqv commented Nov 29, 2020

Who do we ping?

@sorki
Copy link
Member Author

sorki commented Nov 29, 2020

Can't approve my own PR :( We need @imalsogreg for this and for uploading hnix-store-core to Hackage.

imalsogreg
imalsogreg approved these changes Nov 29, 2020
View reviewed changes
Copy link
Collaborator

@imalsogreg imalsogreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@imalsogreg imalsogreg merged commit bc10465 into haskell-nix:master Nov 29, 2020
@imalsogreg
Copy link
Collaborator

@sorki ready for sdist :) Sorry for the slow review.

@sorki
Copy link
Member Author

sorki commented Nov 29, 2020

No worries, thank you! See #76 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imalsogreg imalsogreg imalsogreg approved these changes

@bqv bqv bqv approved these changes

@layus layus layus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sorki @bqv @imalsogreg @layus