Use polling as a generic fallback #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You mean it doesn't ? This seems good to me, we just have to be a careful not to break *BSD since we don't test those in CI. |
amesgen
force-pushed
the
generic-polling-fallback
branch
from
307dc24 to
ece21b6
Compare
amesgen
force-pushed
the
generic-polling-fallback
branch
from
ece21b6 to
c98e8de
Compare
|
This is looking good, just let me know when you're ready for review! |
Thanks, should be ready for review 👍 Also happy to try to set up a CI for WASM if that is desired |
amesgen
force-pushed
the
generic-polling-fallback
branch
from
c98e8de to
f33d5fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, using polling as a fallback if no native watcher is available is only done for BSDs, but I think there is no reason to not simply extend this fallback to all platforms other than Linux, macOS and Windows.
As a motivating example, the WASI target (see the GHC WASM backend) does not provide a native file watching interface. With this patch, fsnotify compiles just fine on that backend, by using the generic polling fallback.