Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3730: Implement Effect tracing #6275

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

indietyp
Copy link
Member

@indietyp indietyp commented Jan 28, 2025

🌟 What is the purpose of this PR?

Implements proper tracing through the use of Effect.fn, this should improve the location of log messages, in the future this can than also be integrated into sentry (H-3977).

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@indietyp indietyp self-assigned this Jan 28, 2025
@github-actions github-actions bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team area/tests New or updated tests labels Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 21.21212% with 182 lines in your changes missing coverage. Please review.

Project coverage is 21.22%. Comparing base (827a1a4) to head (9f122f2).
Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
...pc/client/typescript/src/net/internal/transport.ts 9.52% 76 Missing ⚠️
...ocal/harpc/client/typescript/src/net/Connection.ts 8.69% 42 Missing ⚠️
...al/harpc/client/typescript/src/net/internal/dns.ts 7.89% 35 Missing ⚠️
...rc/wire-protocol/stream/ResponseFromBytesStream.ts 9.09% 20 Missing ⚠️
...s/@local/harpc/client/typescript/src/net/Client.ts 40.00% 3 Missing ⚠️
...l/harpc/client/typescript/src/net/NetworkLogger.ts 25.00% 3 Missing ⚠️
...l/harpc/client/typescript/src/codec/JsonDecoder.ts 89.47% 1 Missing and 1 partial ⚠️
.../typescript/src/wire-protocol/RequestIdProducer.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6275   +/-   ##
=======================================
  Coverage   21.21%   21.22%           
=======================================
  Files         573      573           
  Lines       19658    19637   -21     
  Branches     2870     2870           
=======================================
- Hits         4171     4167    -4     
+ Misses      15435    15418   -17     
  Partials       52       52           
Flag Coverage Δ
apps.hash-ai-worker-ts 1.39% <ø> (ø)
apps.hash-api 1.14% <ø> (ø)
local.harpc-client 49.11% <21.21%> (+0.42%) ⬆️
local.hash-backend-utils 8.81% <ø> (ø)
local.hash-graph-sdk 58.62% <ø> (ø)
local.hash-isomorphic-utils 0.91% <ø> (ø)
local.hash-subgraph 24.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@indietyp indietyp added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit 105bda9 Feb 3, 2025
63 checks passed
@indietyp indietyp deleted the bm/h-3730-implement-effect-tracing branch February 3, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests type/eng > backend Owned by the @backend team
Development

Successfully merging this pull request may close these issues.

2 participants