Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golang.org/x/net to v0.34.0 #29389

Closed
wants to merge 1 commit into from
Closed

Bump golang.org/x/net to v0.34.0 #29389

wants to merge 1 commit into from

Conversation

eualin
Copy link

@eualin eualin commented Jan 22, 2025

Bumps the golang.org/x/net package to mitigate the CVE-2024-45338 vulnerability.

@eualin eualin requested a review from a team as a code owner January 22, 2025 21:37
@eualin eualin requested a review from victorr January 22, 2025 21:37
@divyaac
Copy link
Contributor

divyaac commented Jan 28, 2025

It looks like there are some github conflicts. Once this is resolved, I can take a look at this again!

divyaac
divyaac requested changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@divyaac divyaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are some Git conflicts. Once they are resolved, I'm happy to review this again!

@divyaac divyaac added the dependencies Pull requests that update a dependency file label Jan 28, 2025
@divyaac
Copy link
Contributor

divyaac commented Jan 28, 2025

Closing this as we have already made this change, and it has been backported to 1.17 and 1.16.
#29429
#29422

@divyaac divyaac closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyaac divyaac divyaac requested changes

@victorr victorr Awaiting requested review from victorr victorr is a code owner automatically assigned from hashicorp/vault

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eualin @divyaac