Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1.18.x - UI: LDAP Hierarchical Library names #29384

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Jan 22, 2025

Manual backport for #29293

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

* refactor crumbs

* add subdirectory library route and hierarchical nav

* update library breadcrumbs;

* fix role popup menus

* add getter to library model for full path

* cleanup model getters

* add changelog

* add bug fix note

* add transition after deleting

* fix function definition

* update adapter test

* add test coverage

* fix crumb typo
@hellobontempo hellobontempo added ui backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Jan 22, 2025
@hellobontempo hellobontempo added this to the 1.18.4 milestone Jan 22, 2025
@hellobontempo hellobontempo requested a review from a team as a code owner January 22, 2025 17:58
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 22, 2025
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results: failed ❌

@hellobontempo hellobontempo changed the title UI: LDAP Hierarchical Library names #29293 Backport 1.18.x - UI: LDAP Hierarchical Library names Jan 22, 2025
hellobontempo and others added 4 commits January 22, 2025 16:08
* update ldap mirage scenario to allow check-in/check-out action

* update libraries test to mount engine

* update mirage, fix tests

* update lease renew CLI command

* fix test

* update tests"

Co-authored-by: Chelsea Shaw <[email protected]>
* refactor crumbs

* add subdirectory library route and hierarchical nav

* update library breadcrumbs;

* fix role popup menus

* add getter to library model for full path

* cleanup model getters

* add changelog

* add bug fix note

* add transition after deleting

* fix function definition

* update adapter test

* add test coverage

* fix crumb typo
…ort-1.18.x' of github.com:hashicorp/vault into ui/VAULT-32430/ldap-hierarchical-libaries-support-backport-1.18.x
@hellobontempo hellobontempo deleted the ui/VAULT-32430/ldap-hierarchical-libaries-support-backport-1.18.x branch January 23, 2025 00:17
@hellobontempo hellobontempo restored the ui/VAULT-32430/ldap-hierarchical-libaries-support-backport-1.18.x branch January 23, 2025 00:19
@hellobontempo hellobontempo deleted the ui/VAULT-32430/ldap-hierarchical-libaries-support-backport-1.18.x branch January 23, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants