-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport 1.18.x - UI: LDAP Hierarchical Library names #29384
Closed
hellobontempo
wants to merge
7
commits into
release/1.18.x
from
ui/VAULT-32430/ldap-hierarchical-libaries-support-backport-1.18.x
Closed
Backport 1.18.x - UI: LDAP Hierarchical Library names #29384
hellobontempo
wants to merge
7
commits into
release/1.18.x
from
ui/VAULT-32430/ldap-hierarchical-libaries-support-backport-1.18.x
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor crumbs * add subdirectory library route and hierarchical nav * update library breadcrumbs; * fix role popup menus * add getter to library model for full path * cleanup model getters * add changelog * add bug fix note * add transition after deleting * fix function definition * update adapter test * add test coverage * fix crumb typo
hellobontempo
added
ui
backport/ent/1.17.x+ent
Changes are backported to 1.17.x+ent
labels
Jan 22, 2025
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Jan 22, 2025
Build Results: |
CI Results: failed ❌ |
Co-authored-by: divyaac <[email protected]>
hellobontempo
changed the title
UI: LDAP Hierarchical Library names #29293
Backport 1.18.x - UI: LDAP Hierarchical Library names
Jan 22, 2025
* update ldap mirage scenario to allow check-in/check-out action * update libraries test to mount engine * update mirage, fix tests * update lease renew CLI command * fix test * update tests" Co-authored-by: Chelsea Shaw <[email protected]>
* refactor crumbs * add subdirectory library route and hierarchical nav * update library breadcrumbs; * fix role popup menus * add getter to library model for full path * cleanup model getters * add changelog * add bug fix note * add transition after deleting * fix function definition * update adapter test * add test coverage * fix crumb typo
…ort-1.18.x' of github.com:hashicorp/vault into ui/VAULT-32430/ldap-hierarchical-libaries-support-backport-1.18.x
hellobontempo
deleted the
ui/VAULT-32430/ldap-hierarchical-libaries-support-backport-1.18.x
branch
January 23, 2025 00:17
hellobontempo
restored the
ui/VAULT-32430/ldap-hierarchical-libaries-support-backport-1.18.x
branch
January 23, 2025 00:19
hellobontempo
deleted the
ui/VAULT-32430/ldap-hierarchical-libaries-support-backport-1.18.x
branch
January 23, 2025 00:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/ent/1.17.x+ent
Changes are backported to 1.17.x+ent
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
ui
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport for #29293
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.