Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rootless docker build step #29373

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

VioletHynes
Copy link
Contributor

@VioletHynes VioletHynes commented Jan 21, 2025

Description

This is failing community PRs, and it also seems to make sense to me to keep CE + Ent building the same way.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@VioletHynes VioletHynes requested a review from a team as a code owner January 21, 2025 15:52
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 21, 2025
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@VioletHynes VioletHynes requested a review from kubawi January 21, 2025 16:19
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @VioletHynes !

Copy link
Collaborator

@ryancragun ryancragun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my very quick reading of this, tests that want to exec in a rootless container will no longer be able to in CE CI (which matches Ent). I suppose that is fine if that is the current limitation we have with our runners, though I'm curious what impact this will have?

I'll throw my thumb on this to get the pipeline unblocked but we probably ought to have a follow-up task to investigate whether or not we can re-enable this in some fashion.

@VioletHynes VioletHynes merged commit 47a6855 into main Jan 21, 2025
101 of 104 checks passed
@VioletHynes VioletHynes deleted the violethynes/remove-rootless-docker-step branch January 21, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants